Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Recording
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by darksaboteur - 2007-09-11
Last edited by petur - 2007-09-11

FS#7753 - Recording Enhancements Pack

This is the Recording Enhancements Pack from the forums. I did not create it, I only synced the version from the forum. It is synced to 14667 and only tested on an iRiver H340.

   rep-14667.patch (104.1 KiB)
Closed by  petur
2007-09-11 09:56
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Tracker should only contain one patch at the time, no multiple-changes-in-one-big-lump

pondlife commented on 2007-09-11 08:10

I might be wrong, but I believe this has been rejected in the past for the simple reason that a patch should affect only a single piece of functionality.

This “pack” needs breaking down into multiple small patches, each one with a decent description of what it does.

It’s rather unlikely to be committed otherwise.

darksaboteur commented on 2007-09-11 08:11

I am aware of that and was requested by GodEater to post it here and not in the forums.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing