- Status Closed
- Percent Complete
- Task Type Patches
- Category Recording
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#7753 - Recording Enhancements Pack
This is the Recording Enhancements Pack from the forums. I did not create it, I only synced the version from the forum. It is synced to 14667 and only tested on an iRiver H340.
Closed by petur
2007-09-11 09:56
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2007-09-11 09:56
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Tracker should only contain one patch at
the time, no
multiple-changes-in-one-big-lump
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
I might be wrong, but I believe this has been rejected in the past for the simple reason that a patch should affect only a single piece of functionality.
This “pack” needs breaking down into multiple small patches, each one with a decent description of what it does.
It’s rather unlikely to be committed otherwise.
I am aware of that and was requested by GodEater to post it here and not in the forums.