• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by sdoyon - 2007-09-14
Last edited by sdoyon - 2007-11-07

FS#7777 - Voice for the "Running Time" screen

Speaks the “Running Time” screen (under the “System” menu).

Depends on  FS#7774 : Voice callback for gui_synclist.

Closed by  sdoyon
2007-11-07 03:58
Reason for closing:  Accepted
mlang commented on 2007-09-17 14:29

Thanks for this accessibility fix, I was just about to do something about it when I saw this patch.
THere is one thing I noticed, the patch does not apply cleanly to latest subversion HEAD because
you are using UNIT_TIME, which is not implemented in subversion HEAD.
I fixed it locally by using UNIT_HOUR, UNIT_MIN and UNIT_SEC and doing basically the same modulo and divide
operations that the code for generating string results already uses.
DId you forget to include a dependency on some other patch that provides UNIT_TIME, or is this just an oversight?

mlang commented on 2007-09-17 14:30

Followup to myself: Of course the patch applies cleanly, but it does not compile because UNIT_TIME is not defined…

The UNIT_TIME thing is from my id3 viewer patch in P#6323.
I meant to break it out, since I’ve found use for it here and in my
playing-time patch, but I forgot.

I’ll just attach it here.

Sync’ed with recent gui_synclist_do_button change.
The UNIT_TIME stuff is now in P#7798.

Nope, that was yesterday’s version.. I should go slower. Sorry.
Here it is.


Available keyboard shortcuts


Task Details

Task Editing