FS#7779 - FM Radio Jingle support + talk frequencies if talk_menus is enabled

Attached to Project: Rockbox
Opened by Mario Lang (mlang) - Friday, 14 September 2007, 11:07 GMT
Last edited by Daniel Dalton (ddalton) - Wednesday, 05 December 2007, 08:35 GMT
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Operating System SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch adds jingle support to the FM tuner.
If a subdirectory /.rockbox/fmpresets/jingles/ exists and contains
a file named stationname.mp3, this file will be played back when the
station is changed or upon entering the FM tuner screen.
Just populate your jingles directory with mp3 jingles of your
favourite stations (less than 32KB).
If no such file is found, the frequency is spoken if talk_menus is enabled.
This task depends upon

Closed by  Daniel Dalton (ddalton)
Wednesday, 05 December 2007, 08:35 GMT
Reason for closing:  Rejected
Additional comments about closing:  From a descussion on irc a while back it looks like not many people like the idea. Nice patch but I think now with St├ęphane's patch for radio been excepted we do not need this.
The voicing radio patch is
Reopen if I am wrong.
Comment by Daniel Dalton (ddalton) - Friday, 14 September 2007, 11:14 GMT
It sounds simular to p6331.
Is there any difference?
Comment by Mario Lang (mlang) - Friday, 14 September 2007, 11:43 GMT
6331 looks a lot more complicated (and actually outdated)
This patch (7779) is a just a few lines and does not change anything in the language files at all.
It only tried to playback a jingle file using talk_file() and if that fails, announces the frequency in kilohertz using talk_value().
Comment by Daniel Dalton (ddalton) - Saturday, 15 September 2007, 06:17 GMT
It doesn't say the station as a decimal. For example it doesn't say 101.9.
Also Stephane's patch says the preset name if in preset mode otherwise says the frequency with a decimal.