Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category FM Tuner
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mlang - 2007-09-14
Last edited by ddalton - 2007-12-05

FS#7779 - FM Radio Jingle support + talk frequencies if talk_menus is enabled

This patch adds jingle support to the FM tuner.
If a subdirectory /.rockbox/fmpresets/jingles/ exists and contains
a file named stationname.mp3, this file will be played back when the
station is changed or upon entering the FM tuner screen.
Just populate your jingles directory with mp3 jingles of your
favourite stations (less than 32KB).
If no such file is found, the frequency is spoken if talk_menus is enabled.

Closed by  ddalton
2007-12-05 08:35
Reason for closing:  Rejected
Additional comments about closing:  

From a descussion on irc a while back it looks like not many people like the idea. Nice patch but I think now with Stéphane's patch for radio been excepted we do not need this.
The voicing radio patch is
 FS#6331  Reopen if I am wrong.

It sounds simular to p6331.
Is there any difference?

mlang commented on 2007-09-14 11:43

6331 looks a lot more complicated (and actually outdated)
This patch (7779) is a just a few lines and does not change anything in the language files at all.
It only tried to playback a jingle file using talk_file() and if that fails, announces the frequency in kilohertz using talk_value().

It doesn’t say the station as a decimal. For example it doesn’t say 101.9.
Also Stephane’s patch says the preset name if in preset mode otherwise says the frequency with a decimal.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing