Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by linuxstb - 2007-09-25
Last edited by saratoga - 2010-07-02

FS#7831 - FLAC files with "unknown" total samplecount are rejected

The current Rockbox FLAC codec rejects files (in apps/metadata/flac.c) where the “samplecount” field in the header is 0. However, the FLAC specification says that this is a valid value and should be interpreted as “unknown”.

The only encoder I’ve seen which generates such files is ffmpeg.

Closed by  saratoga
2010-07-02 18:42
Reason for closing:  Accepted
Additional comments about closing:  

Accepted in r27244.

When totalsamples (samplerate) is 0, length and bitrate are set to 0 because their calculation depends on samplerate, else behave as before. Setting the length to 0 removes the possibility for seeking during playback, but the file is still loadable and playable.

This is my first patch, all comments and suggestions are appreciated.

Josh

Just some slight modifications to apply to current build (16460) without fuzz factor.

Resync (just offset lines)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing