• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rbx-multiplex - 2007-09-28
Last edited by nicolas_p - 2007-11-18

FS#7856 - WPS image not clearing fully

There is an issue with images not clearing properly, it is easily demonstrated with the enclosed WPS (H300 but I have no reason to believe that it is device specific).

When clearing the lock icon(M) it leaves the right hand column of pixels behind.

Sometimes it clears later when other bits of the screen
can allways be cleared by locking both the main and remote and clearing the main first.

It can be worked arround by modifying a different image (I added a transparent column to the R, making it bigger) - but this does not have to be displayed to ‘fix’ the
on a real unit and Rasher’s
not bothered about the issue but as it’s such an easy re-create I thought it might help to fix it.

Closed by  nicolas_p
2007-11-18 15:33
Reason for closing:  Fixed

Where did the WPS file go...

That’s an interesting problem... The reason for it is that images are cleared when the conditional they are in changes value. However from the structure of your WPS, all images belong to %?mr conditionals (a picture an only belong to one conditional), which means toggling the main hold switch will never clear the hold
line that remains is the same issue of not clearing the picture because it’s not found to be in the conditional that changes
may sound like a strange limitation, but it is a hard one to
suggest using three distinct pictures (i, j and k), all including the lock, with the same dimensions and no transparency. The following code works:


Picture i is cleared when main hold is toggled. j is cleared when remote hold is toggled. k is cleared when main hold is toggled (not remote hold), but the order of display ensures that it works properly.

Well after a bit of thought, I realized removing that limitation I was talking about wasn’t has hard as I thought, so I have a fix almost ready to commit. It makes your WPS work perfectly without any changes.


Available keyboard shortcuts


Task Details

Task Editing