Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dionoea - 2007-09-30
Last edited by dionoea - 2007-10-15

FS#7875 - Remove gui list flash / lcd scroll invert code.

This removes the invertscroll functions in firmware/drivers/ and the gui_(sync)list_flash functions in apps/gui/. This code was only used by the playlist_viewer when moving an item. Since we have a specific icon to flag the track to be moved this was redundant (and it didn't work well with the new gradient/colored selection bar code). This saves about 500 bytes on the ipod video build.

   scrollinvert-remove.patch (8.4 KiB)
Closed by  dionoea
2007-10-15 20:52
Reason for closing:  Accepted
jdgordon commented on 2007-10-01 08:24

if icons are disable in that screen how will you know what your moving?

dionoea commented on 2007-10-01 10:22

Ah, that was something I wasn't sure about. How do you disable the icons? Is it a playlist viewer specific setting or a general rockbox setting?
(Anyway, the blinking line isn't set on the item to move but on the line you're moving it to … I'm not sure if that's the way it's supposed to be though)

jdgordon commented on 2007-10-01 10:25

I tinhk the playlist viewer has its own show icons setting in its settings menu (not the playlist options settings under the main menu…)

bluebrother commented on 2007-10-01 11:40

Press "Menu" in the playlist to access its settings. I personally find the flashing line / icon rather confusing, I'd better like to move the entry "live" in the playlist viewer when moving. That way flashing also wouldn't be needed …

dionoea commented on 2007-10-01 11:47

These screenshots show the current code (well, a build from a week ago) with and without icons. The flashing line is never set on the item to move (note that when icons are disabled you don't see what item was selected). The flashing line is useless when used that way in my opinion, since I fail to see why a non flashing selector would convey a different meaning.

Edit: line Ccc is selected in both screenshots (which isn't easy to notice in the second one)
Edit2: And I agree with bluebrother that moving the item on the fly would be more intuitive (although that would be a completely different patch then removing a bunch of almost unused functions).

   dump 071001-134215.bmp (45.4 KiB)
   dump 071001-134402.bmp (45.4 KiB)
dionoea commented on 2007-10-14 22:05

See FS #7958 for an implementation of bluebrother's idea.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing