Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System SW-codec
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Mark Arigo - 2007-10-09
Last edited by Jonathan Gordon - 2008-11-09

FS#7916 - Adapt graphical EQ to smaller screens

The current graphical eq screen does not fit all five bands onto the smaller screen of the Sansa c200 (132×80). This patch allows the screen to scroll in order to access all the bands. Also, rather than keep the special case for the remote screen, it is now displayed in a similar manner.

I tested this on the c200 (device & sim) and on the h120 sim in order to test the remote display. On most devices, it should not look any different because all five bands fit on the display.

More testing welcome, as are comments.

Closed by  Jonathan Gordon
2008-11-09 10:28
Reason for closing:  Accepted
Additional comments about closing:  

easier than I thought to fix the draweing glitches… commited

Dan Everton commented on 2007-10-09 20:43

Just quickly reviewed the patch. Looks good. I’d say commit it.

Dan Everton commented on 2007-10-10 09:39

Actually now that I’ve tested it on my H120 I’ve found that the controls don’t work on the LCD remote. You can navigate between the bands and the settings but not change them.

Mark Arigo commented on 2007-10-10 13:02

Could you change them before using the remote? I don’t think I touched the any button code.

Dan Everton commented on 2007-10-10 20:36

Nope, can’t change the settings from the remote in a normal build. So your patch hasn’t changed anything there. Looking closer it seems there’s no rc key context for the eq, but that can be fixed later.

Dominik Riebeling commented on 2007-10-20 19:42

I had a quick look at this. There are some display issues (tried on ipod mini sim):
- going from PK3 to HS gives a really strange effect with the display kinda jumping around
- the text is cropped due to the limited size of the display (the “0.0dB” shows only “0.0c”, the Q value only shows the last digit)

Dave Chapman commented on 2007-10-20 20:04

Sync with SVN r15227

William commented on 2008-07-03 06:09

I’m getting a hunk failure. Any chance for a re-sync? Thanks in advance.

Jonathan Gordon commented on 2008-11-09 10:03

sync… the screen issues Dominik mentioned are still there and only seem to appear on the mini sim… planning to have a bit more of a play with this to fix  FS#9517 

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing