Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Magnus Holmgren - 2003-01-19
Last edited by Björn Stenberg - 2003-06-04

FS#792 - Add support for APE tags

This patch adds support for so called APE tags, which
are simple but flexible tags located at the end of a
file. I decided to add support because Foobar2000
(http://foobar2000.hydrogenaudio.org/) uses it as it’s
main tag format (ID3V2 isn’t supported).

Note that this patch hasn’t been tested much. This is
especially true for the UTF-8 reader… It works on a
couple of test files though.

   ape.h (1.7 KiB)
   ape.diff (6.3 KiB)
   ape.c (15.3 KiB)
   ape.zip (5.9 KiB)
Closed by  Björn Stenberg
2003-06-04 12:25
Reason for closing:  Rejected
Additional comments about closing:  

Logged In: YES
user_id=1157

Too esoteric for inclusion in mainline Rockbox.

Magnus Holmgren commented on 2003-03-16 18:45

OK, here’s a new version of the APE tag patch. Changes:

* Modifies mpeg.c to make it support gapless playback of
PE-tagged files. Tested it with 20 kB tags (on –nogap files
created by Lame); worked just fine.

* Should better handle the case where the current read does
not load the entire tag, and the part loaded in the previous
read (which is likely to be in the MP3 buffer) has already
been bitswapped. I say should, because it is a bit tricky to
test this properly. ;)

This means that perhaps the code commented like this should
be removed: “/* The very rare case when the entire tag
wasn’t read in this read() call must be taken care of */”…

* Modifies app.lds. Without the last .align, I got a binary
that was an odd number of bytes long. The scrambler doesn’t
like that. (The current patch may or may not need them; in
any case, they won’t hurt.)

* Added support for Year tag. Genre isn’t supported (yet),
since it is a free-text string (which may or may not match
one of the pre-defined genres).

* Available in an unzipped version. :)

Unfortunately, I need to use the -b option (diff finds lots
of changes
otherwise), so the indentation is wrong in some places…

Admin
Björn Stenberg commented on 2003-06-04 12:25

Too esoteric for inclusion in mainline Rockbox.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing