• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface
  • Assigned To
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2007-10-14
Last edited by jdgordon - 2007-10-15

FS#7952 - Balance setting menu in sound settings menu selects incorrect previous balance setting (sansa e200)

* sansa e200 with r15107 firmware

How to reproduce:
* Play a song and go to WPS
* Go to context menu / Sound settings menu
* Select Balance menu item and set balance to +20%, exit Balance menu item
* Select Balance menu item again: balance is now set to -20% (instead of previous +20%)

My analysis:
I think this is related to a change in SVN revision 14288 in apps/settings_list.c that introduced a BALANCE_FLIP flag to the balance menu item that flips the list order. This makes setting balance more intuitive for scroll-wheel devices (like sansa e200 and ipods), where dialing clockwise can mean both 'down' and 'more/louder/right'.

The code block in apps/gui/option_select.c line 332 does not check for this flag and thus selects the incorrect list index for lists with flipped list order.

Closed by  jdgordon
2007-10-15 05:35
Reason for closing:  Accepted

Here's a simple fix.


Available keyboard shortcuts


Task Details

Task Editing