• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2007-10-15
Last edited by nls - 2007-10-20

FS#7966 - Incorrect menu captions in playback control menu (always 'Yes')

* Sansa e260 with r15122

How to reproduce:
* Start a game plugin that has an ‘Audio Playback’ menu, e.g. sokoban or solitaire.
* Enter the Audio Playback menu and select either ‘Change Volume’, ‘Enable/disable shuffle’ or ‘Change repeat mode’: menu caption of sub-menu is always ‘Yes’.

* the last argument in all function api→option_screen callbacks (title) is NULL.
* ‘Yes’ is the text for language id 0.

Closed by  nls
2007-10-20 21:56
Reason for closing:  Accepted

Here’s a simple patch that fixes it. It doesn’t do internationalisation though, I get compile errors when I try to #include lang.h

It turns out that plugins don’t support internationalisation (yet), so I think using literal strings is a valid way to solve the problem.


Available keyboard shortcuts


Task Details

Task Editing