Rockbox

Tasklist

FS#7971 - mpegplayer - start menu loads quicker - menu clean up - code clean up

Attached to Project: Rockbox
Opened by Brian Morey (Morey) - Tuesday, 16 October 2007, 04:33 GMT
Last edited by Robert Kukla (roolku) - Tuesday, 16 October 2007, 14:24 GMT
Task Type Patches
Category Video
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch adds the following functionality to the mpegplayer plugin:

() Startup menu loads quicker

() Menu cleanup: moved some of the display option settings into the display options menu

() Code cleanup:
lined up some brackets
added enum ids for menu selections


This patch has been written by:
Brian J. Morey
This task depends upon

Closed by  Robert Kukla (roolku)
Tuesday, 16 October 2007, 14:24 GMT
Reason for closing:  Accepted
Comment by Brian Morey (Morey) - Tuesday, 16 October 2007, 04:51 GMT
On the Sansa e200 the start up menu now loads in about 3 seconds compared to 7 seconds previously.
Comment by Brian Morey (Morey) - Tuesday, 16 October 2007, 05:03 GMT
This version of the patch adds the ability to exit mpegplayer by pressing the power button. This follows the standard action of the other menus in mpegplayer where the power button exits the menu.
Comment by Antoine Cellerier (dionoea) - Tuesday, 16 October 2007, 08:59 GMT
I don't know mpegplayer well enough to comment on that patch. I just wanted to mention that you can use the "svn diff" command in the mpegplayer directory to create a diff (If you checked out the source code using svn). You don't need to have 2 different trees on your harddrive.

Loading...