FS#7981 - Missing tag data (and crashing) if WMA track has comment

Attached to Project: Rockbox
Opened by Shiloh Hawley (gree665) - Wednesday, 17 October 2007, 06:17 GMT
Last edited by Marc Guay (Marc_Guay) - Monday, 31 March 2008, 23:52 GMT
Task Type Bugs
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System iPod 4G Grayscale
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The WPS does not display album name, genre, or track number, on certain WMA tracks (it does always display artist name and song title). This problem seems to correspond to whether I have a comment in the WMA track tags. If I don't have a comment, everything displays fine, if I do, then the data I mentioned is missing. Mp3 and FLAC do not seem to have this problem.

Also on these tracks (WMA with comments), the player freezes when I go to 'Show Track Info' from the WPS Context Menu.

(Also I've not been able to build my database since I put a bunch of WMA tracks on my player, I don't know yet if this is for the same reason)

I tested this with release 15162.
This task depends upon

Closed by  Marc Guay (Marc_Guay)
Monday, 31 March 2008, 23:52 GMT
Reason for closing:  Fixed
Additional comments about closing:  Database building doesn't choke on long tags, nor does Show Track Info cause problems. Tested with the file from  FS#8500  .
Comment by Dave Chapman (linuxstb) - Wednesday, 17 October 2007, 17:29 GMT
Would you be able to provide a sample file demonstrating this bug?
Comment by Shiloh Hawley (gree665) - Wednesday, 17 October 2007, 17:43 GMT
Sure I will attach it here. The comment tag is from the Tag&Rename program. I found that if I got rid of the comment, the problem went away.
Comment by Shiloh Hawley (gree665) - Thursday, 25 October 2007, 05:46 GMT
I was mistaken above when I said mp3 and flac files do not have the same problem. I have seen the same problem with a some mp3 files as well. If anyone would like more information, testing, samples, etc, please let me know.
Comment by Dave Chapman (linuxstb) - Sunday, 28 October 2007, 13:22 GMT
I've finally got around to testing your file.

There appears to be two problems:

1) Rockbox only has a relatively small buffer available for storing the metadata about a track. This buffer is filled in the order the tags are in the file, and because the comments tag comes before the other data, this means the buffer is full before it can read those remaining fields, so it skips them. This may be changed now that the "metadata-on-buffer" feature has been implemented.

2) There does seem to be a bug in the "view track info" screen which causes Rockbox to freeze when displaying a very long comment. I haven't investigated this any more.

Comment by Shiloh Hawley (gree665) - Sunday, 28 October 2007, 16:12 GMT
Ok thank you for looking into it. I'll test it again with the latest firmware. I'm not particularly attached to the comments, so stripping them off isn't a problem for now.