• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2007-10-19
Last edited by pondlife - 2007-10-19

FS#7994 - Revised interface for talk_disable(), now disables all talking, not just menu

This replaces the talk_disable_menus() and talk_enable_menus() interfaces with a single talk_disable(bool disable) interface.

Disabling now affects all talking, not just menus. The talk_menus_enabled() routine has been scrapped as the temporary disabling is now handled internally to talk.c.

Closed by  pondlife
2007-10-19 15:32
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Worth committing for the API simplification, I reckon.

Note that this revises the initialisation of mpegplayer to incorporate  FS#7939  too.

This one re-enables talking on all exits from mpegplayer.

This one clears queued clips when talking is disabled - this fixes mpegplayer for me too.

OK, patch expanded to standardise talk API function names and generally tidy up talk.c. Should be functionally the same as v3 though.

No point in forcing shutting up talking immediately as that happens anyway when IRAM is stolen.


Available keyboard shortcuts


Task Details

Task Editing