Rockbox

Tasklist

FS#8011 - User configurable settings in main menu

Attached to Project: Rockbox
Opened by Costas Calamvokis (cc) - Sunday, 21 October 2007, 20:36 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 22 October 2007, 12:39 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This little patch allows users to put commonly used settings in the root menu for quick access. You just have to put the setting followed by +root in a .cfg file. You can also include the whole menu containing a particular setting by using *root. For example.

brightness: +root
invert: +root
autoload bookmarks: *root
foreground color: *root
scan min step: +root
party mode: +root

See the attached fixed.cfg for more usage details.

Up to 10 items can be added.

This is a pretty no-frills implementation - I tried to keep it as simple as possible.

There was some discussion on the forum too:
http://forums.rockbox.org/index.php?topic=13277.0

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 22 October 2007, 12:39 GMT
Reason for closing:  Rejected
Additional comments about closing:  we have no desire to make the menus customizable
Comment by Costas Calamvokis (cc) - Sunday, 21 October 2007, 21:25 GMT

Changed references to "root" to "main" after comments from bluebrother in the forum. The cfg now looks like this:

brightness: +main
invert: +main
autoload bookmarks: *main
foreground color: *main
scan min step: +main
party mode: +main

Comment by Mark Fawcus (yapper) - Monday, 22 October 2007, 01:17 GMT
I like this patch. The only snag I hit was compiling for a target that has only a B&W LCD gave me the following errors:
menu.c: In function 'get_setting_menu_item':
menu.c:605: error: 'struct user_settings' has no member named 'fg_color'
menu.c:607: error: 'struct user_settings' has no member named 'lss_color'
make[1]: *** [/home/M/rockbox2/build/apps/menu.o] Error 1
make: *** [build] Error 2
Once I hacked those cases out of your 'special hacks' it compiled fine, and works great (on my 2Gipod)
Comment by Costas Calamvokis (cc) - Monday, 22 October 2007, 08:14 GMT

Thanks for the feedback Mark - here's a fixed version for non-colour targets.
(I also removed the special case for the eq which isn't needed)

Loading...