FS#8014 - remove LCD-wait in YUV-blit

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Tuesday, 23 October 2007, 06:35 GMT
Last edited by Robert Kukla (roolku) - Wednesday, 31 October 2007, 16:16 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


During playing around with the YUV-blit function for the iPod Video I came around the following idea and tested it: One major delay of the Video's LCD-driver is the sequence where we wait for the LCD to be ready for the next screen update. This always needs 14ms, so the drivers yields in such situation.

1st try: Do not wait, but always update the LCD.
This shows a significant speed-up for all videos from a resolution of 224x176 and lower. A maximum of 75fps (before: 47) is reached at 128x96. Nevertheless we very rarely get some errorous pixels while playback. Conclusion: The yielding does not improve the decoding performance.

2nd try: Do not wait, but drop the whole frame update when LCD is not ready.
This will kind of destroy the YUV-blit-measurement in test_fps, but has even more positive effect on the video playback. In this case the yuv-conversion as well as the transfer to LCD's data port is dropped, the next possible update will take place. While video playback the yuv-blit function is called in a cyclic manner. So, you will therefor not loose any frame as there has been no LCD update at all while the former implemented yielding. Effect is that you get a really significant increase in video playback from 224x176 (now: 28fps, before: 24fps) which goes up to 107fps for 128x96.

This change can only be done as yuv-blit is called repeatedly and cannot be applied to lcd_update_rect(). There is no interference with lcd_update_rect().
This task depends upon

Closed by  Robert Kukla (roolku)
Wednesday, 31 October 2007, 16:16 GMT
Reason for closing:  Rejected
Additional comments about closing:  as requested by author
Comment by Robert Baker (momo_101) - Friday, 26 October 2007, 01:47 GMT
Any chance that this works with the iPod Color/Photo too?
Comment by Dagni McPhee (donutman25) - Monday, 29 October 2007, 06:14 GMT
according to the patch it only works on ipod video