FS#8040 - Gather Runtime Data stopped working with r15306

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Sunday, 28 October 2007, 16:31 GMT
Last edited by Robert Kukla (roolku) - Friday, 23 November 2007, 01:15 GMT
Task Type Bugs
Category Database
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No


The "Gather Runtime Data" feature of the DataBase doesn't work anymore. The data that was collected before updating to a build after r15306 still shows up in the WPS and database browser, but it doesn't get updated anymore.

tested with H300 uisimulator (Cygwin on WindowxXP) (with r15305 it worked; with r15306 and r15436 it didn't work)
This task depends upon

Closed by  Robert Kukla (roolku)
Friday, 23 November 2007, 01:15 GMT
Reason for closing:  Fixed
Additional comments about closing:  Now also saving rt info for the last track of the playlist.

The "unnecessary" calls are in fact neccessary for possible backwards skipping so they need to stay.
Comment by Brandon Low (lostlogic) - Saturday, 03 November 2007, 23:52 GMT
Once we figure out a good way to get the played statistics onto the metadata stored on buffer, this will work, I've adjusted the track clearing order. I think.
Comment by Ralph Welz (WRPSoft) - Tuesday, 13 November 2007, 09:30 GMT
I don't know, whether it's the same kind of error or not, but on my iRiver iHP-120 the database user rating feature isn't working anymore with the current releases. I 'm able to rate a song via the 'context menue' and the new 'combobox style rating editor', but it seems, that the assigned ratings aren't stored permantly in the database. Only the former assigned songs are rated furthermore (assigned under version r15427-071103).

Target define: -DIRIVER_H120
Memory: 32
CPU: coldfire
Manufacturer: iriver
Version: r15596M-071112
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 13 November 2007, 11:23 GMT
There's a good chance that it's the same problem, yes.
Comment by Robert Kukla (roolku) - Thursday, 22 November 2007, 16:06 GMT
While it works a lot better with r15748 there is still an outstanding problem. :(

The last track of a playlist is not recorded, neither is the current track when you press stop (although for the latter there is still an ongoing debate on whether it should be)

Looking at some debugging info, it is the usual case of calling with elapsed time = 0.

In fact there are quite a lot of unnecessary calls with an invalid elapsed time of 0, i.e. when you press stop for all the tracks after the currently playing one, or when you change the repeat mode (I guess whenever buffered tracks get discarded). They don't however cause any problems (apart from the extra execution time I suppose).