FS#8049 - MoB: Incomplete buffering on flash-based targets.

Attached to Project: Rockbox
Opened by Magnus Holmgren (learman) - Tuesday, 30 October 2007, 12:17 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Tuesday, 30 October 2007, 17:24 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When playing music on a Sansa (probably any flash-based player), the file buffer is rarely filled to capacity. buffering.c seem to rely on ata_disk_is_active() to return true to make full use of the buffer, but it always return false on flash targets. This behavior can be seen in the simulator by changing the ata_disk_is_active define (in buffering.c) to 0.

This could perhaps explain some strange buffering behavior on the Sansa, like occasional buffer under-runs or  FS#8037 .
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Tuesday, 30 October 2007, 17:24 GMT
Reason for closing:  Fixed