• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2007-10-30
Last edited by nicolas_p - 2007-10-31

FS#8053 - playback.c simplification by removal of last_track argument in track_(un)buffer callback

This patch simplifies playback.c a bit by removing the last_track argument from track_buffer_callback and track_unbuffer_callback in playback.c and mpeg.c. The last_track argument is no longer used anywhere.

Removal of the argument allows further simplification of functions audio_clear_track_entries and audio_generate_postbuffer_events in playback.c by removing the need for special handling of the last track entry.

Closed by  nicolas_p
2007-10-31 13:44
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407


Attached patch (against 15380) does further simplification in mpeg.c, made possible by the removal of the last_track argument.


Available keyboard shortcuts


Task Details

Task Editing