FS#8069 - mp3 vbr gapless is broken with r15306

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Friday, 02 November 2007, 06:58 GMT
Last edited by Brandon Low (lostlogic) - Wednesday, 28 November 2007, 04:59 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I updated ipod-video simulator with r15306.
And I found that mp3 vbr gapless was broken with default configuration.

So I downgraded r15305.
Then mp3 vbr gapless was successfully.

I think that new metadata on buffer is the cause.
   02.mp3 (1.51 MiB)
   03.mp3 (1.53 MiB)
This task depends upon

Closed by  Brandon Low (lostlogic)
Wednesday, 28 November 2007, 04:59 GMT
Reason for closing:  Fixed
Additional comments about closing:  15840
Comment by Nicolas Pennequin (nicolas_p) - Friday, 02 November 2007, 18:38 GMT
This is just a guess, but maybe it's due to the fact that tags aren't stripped from the audio files anymore in MoB. Other than that I can't think of anything for now.
Comment by Brandon Low (lostlogic) - Saturday, 03 November 2007, 18:14 GMT
That sounds like a good guess Nico, we probably need to tell the codecs about that.
Comment by Akio Idehara (idak) - Friday, 16 November 2007, 15:02 GMT
I have deleted ID3v1 tag from all mp3 files for the time being...
Comment by Brandon Low (lostlogic) - Wednesday, 28 November 2007, 04:48 GMT Comment by Brandon Low (lostlogic) - Wednesday, 28 November 2007, 04:56 GMT
Never mind, I've confirmed the fix with the test files posted here and am committing, happy gaplessing.