Rockbox

Tasklist

FS#8071 - Database search for "Same as current album" not working

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 02 November 2007, 12:23 GMT
Last edited by Robert Kukla (roolku) - Friday, 02 November 2007, 16:50 GMT
Task Type Bugs
Category Database
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Going into the Database > Same as current > Album menu never finds any matches.

The Directory, Title, Artist options all work fine, and I've tried re-initialising my database.
This task depends upon

Closed by  Robert Kukla (roolku)
Friday, 02 November 2007, 16:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  removed albumartist match requirement
Comment by Robert Kukla (roolku) - Friday, 02 November 2007, 14:18 GMT
Hm, to be the "same album" currently requires a match on the album tag as well as on the albumartist tag. I guess the latter is not used in your case? Maybe I should remove that dependency which on the other hand makes the #albumartist# tag rather useless...
Comment by Steve Bavin (pondlife) - Friday, 02 November 2007, 14:54 GMT
Maybe it's that, but even so I'd think that the search should at least find the currently playing track - it's bound to have the same albumartist too.

Or is a missing tag resulting in it being missed? I don't generally set up albumartist.
Comment by Robert Kukla (roolku) - Friday, 02 November 2007, 15:08 GMT
Empty/missing tags will match nothing, so if you haven't set up your albumartist the behaviour is as expected (although not very useful). The question is do I remove the check for albumartist or do I derive it from artist (as the database does). The former will render #albumartist# useless (so it should be removed) the latter implies a special treatment for albumartist. The second option will also not help if the current track has no artist tag.
Comment by Steve Bavin (pondlife) - Friday, 02 November 2007, 15:20 GMT
I'd expect the same album option to find anything with the same album title, regardless of artist, to be honest. We don't seem to make the same restriction for Tracks.

Or it may be better if a missing tag could be matched (i.e. NULL == NULL) in some manner, so that this would find entries with the same album title, and NO albumartist tag. I suspect the way the database works won't allow for this.

Or it could notice that the current track has no albumartist tag, and so ignore that filter (i.e. only require the album tag to match).
Comment by Robert Kukla (roolku) - Friday, 02 November 2007, 16:50 GMT
considering the tagnavi syntax doesn't support the OR operator, your suggested special case handling for albumartist would have to be done in code and I really want to keep that generic/the same for all tags (KISS)

Loading...