Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by linuxstb - 2007-11-11
Last edited by linuxstb - 2007-11-12

FS#8135 - Add xoffset parameter to %s (left scroll-margin)

The attached patch adds an optional parameter to the %s tag to specify the left scroll margin - e.g. %s|100|

This is implemented without changing the LCD drivers - it makes use of the existing ability to set a left margin in scrolling lines.

I’m hoping this patch can be committed to enable people to design album-art WPSs that can work with official Rockbox builds - album art isn’t very usable without it.

It’s partly based on the existing scrollmargins patch, but removes all the parts related to the right margin, which causes the most intrusion into the rest of Rockbox - this patch only modifies the WPS code.

   left_scrollmargin.diff (6.9 KiB)
Closed by  linuxstb
2007-11-12 21:34
Reason for closing:  Accepted
Llorean commented on 2007-11-11 23:01

I’m all for committing this. If the lcd setmargin() function is going to be removed with Viewports, then removing this code shouldn’t be significant anyway, as it looks like a fairly small patch. And if it doesn’t get removed then this patch would stay useful.

tdtooke commented on 2007-11-12 08:55

I’m all for anything that would motivate more people to create album art themes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing