FS#8181 - Mpegplayer: Don't save settings when pausing

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Sunday, 18 November 2007, 23:28 GMT
Last edited by Peter D'Hoye (petur) - Wednesday, 16 January 2008, 13:21 GMT
Task Type Feature Requests
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When pausing video playback in the mpegplayer this causes the settings to be saved in order to preserve the resumepoint in case of an idle poweroff. This feature was introduced by revision 15079.
On targets with a harddrive this causes a delay of 2-3 seconds from pressing the button until the video actually pauses, which can be bad if you for example pause in order to read a subtitle.

So it would be nice if the settings/resumepoint would only be saved when the device is actually about to shut down. I think the function button_get() returns SYS_POWEROFF when the device is going to shut down, so this could propably be used to trigger the settings saving.
This task depends upon

Closed by  Bj√∂rn Stenberg (zagor)
Wednesday, 16 January 2008, 13:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  Closing all feature requests.
Comment by Michael Sevakis (MikeS) - Monday, 19 November 2007, 00:07 GMT
The pause delay won't happen in my update that I'll get back to work on once the voice format change thing cools down. It saves on exit only (remembers on stop) but will add the idle poweroff handling too.