Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System PortalPlayer-based
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sheng-xiang tang - 2007-11-19
Last edited by Dave Chapman - 2007-11-20

FS#8189 - USB driver and stack complement for PP502x

Some fixes in driver arcotg_dcd.c to treat other endpoints than ep0, and add callback to treat other commands than setup

Implement SCSI commands treatement in usb_storage.c

Enable ATA access in USB connected mode (usb.c) to read/write sectors etc

All exchanges seem OK (tested with a iRiver H10 20G with Windows XP), and even one time the whole iRiver disk is accessible via Windows but in most case there is a PANIC !

Remain to do: implement read capacity and write sector in usb_storage.c, find out the panic cause

   usb.c.diff (2 KiB)
   usb_storage.c.diff (27.7 KiB)
   usb_storage.h.diff (11.3 KiB)
   arcotg_dcd.c.diff (4.5 KiB)
   controller.h.diff (0.4 KiB)
Closed by  Dave Chapman
2007-11-20 12:21
Reason for closing:  Rejected
Additional comments about closing:  

This patch consists mainly of third-party code which isn't under an open-source license, and hence we can't use it in Rockbox.

In addition, the intention is to replace the existing USB code with  FS#7962  so you should work with that patch, rather than the code currently in SVN.

Admin
Daniel Stenberg commented on 2007-11-19 15:57

Please check out  FS#7962 , as that's Zagor's work on a(nother) USB stack that is likely to go in instead of this first one.

At least you two should have a talk and see what can be done to merge your efforts to drive progress forward jointly!

Admin
Daniel Stenberg commented on 2007-11-19 16:09

Eek, is this code not written by yourself? It looks very much like code from the URL you mention in the source code:

http://ww1.microchip.com/downloads/en/AppNotes/MCHPMSD.zip

… and the copyright texts and license headers of all sources in that package clearly says we cannot use that code in Rockbox!

Christian Gmeiner commented on 2007-11-19 17:09

Thanks for your work to do the final stuff to get it up and running, but it seems that my stack is not wanted as it is too generic.

Dave Chapman commented on 2007-11-19 18:05

For reference, here is the license text for the original code from MCHPMSD.zip - the patches here to usb_storage.[ch] seem to consist of only code from that zip file:

* Software License Agreement
*
* The software supplied herewith by Microchip Technology Incorporated
* (the <93>Company<94>) for its PICmicro? Microcontroller is intended and
* supplied to you, the Company<92>s customer, for use solely and
* exclusively on Microchip PICmicro Microcontroller products. The
* software is owned by the Company and/or its supplier, and is
* protected under applicable copyright laws. All rights are reserved.
* Any use in violation of the foregoing restrictions may subject the
* user to criminal sanctions under applicable laws, as well as to
* civil liability for the breach of the terms and conditions of this
* license.

sheng-xiang tang commented on 2007-11-19 18:39

 FS#7962  implementation seems more complete

Yes, the scsi part is directly updated from http://ww1.microchip.com/downloads/en/AppNotes/MCHPMSD.zip, it seems that it should be removed

arcotg_dcd.c file may be used combined with  FS#7962 : it seems the management of index (mask) is wrong (send & receive functions) for endpoints other than ep0. the enable function seems have USB_SEND & USB_RECEIVE inversed

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing