Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To
    rasher
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2007-11-21
Last edited by rasher - 2008-07-20

FS#8207 - buildzip.pl cleanup

This is my first stab at converting buildzip.pl to use native perl functions, rather than calling external apps (causing a pretty hefty slowdown on cygwin). So far, I’ve simply gone for the low-hanging fruit - simple cp and mv operations.

A recursive delete function should be fairly simple (to replace “rm -rf”).

The next step is probably to write a sort of “find” implementation that takes a search expression and a callback function or something like that. It doesn’t need to be a full find replacement of course. Just enough to do what buildzip needs (find and copy, I believe).

This will need a fair bit of testing of course, since we don’t want the zips to be broken.

   buildzip-cleanup-fs8207.diff (4.5 KiB)
Closed by  rasher
2008-07-20 22:39
Reason for closing:  Accepted
Additional comments about closing:  

Committed as r18108

rasher commented on 2008-07-20 21:11

Updated patch. Most things have been changed from shelling out to using Perl functionality.

Hopefully this provides a nice speedup.

I *think* this produces identical zip files to current SVN.

   buildzip-cleanup-fs8207-v2.di... (7.3 KiB)
rasher commented on 2008-07-20 22:10

Fixed a few issues:
- Cleanup .cp files
- Remove a leftover printf
- Actually create .rockbox/database.ignore
- Pipe all zip output to /dev/null

   buildzip-cleanup-fs8207-v3.di... (7.5 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing