Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sdoyon - 2007-11-27
Last edited by sdoyon - 2007-11-27

FS#8236 - make voice should overwrite existing .voice files.

Rerunning make voice generates an english-1.voice, and then again an
english-2.voice… There's extra code to do this, so perhaps there's a
reason for this behavior? I can't imagine what it is.

I find this inconvenient and confusing. I was trying out encoder settings
and it took me a while to figure out that my english.voice wasn't
actually being regenerated.

So unless there's a reason for this, I'd like to commit the attached
patch.

   overwrite-dot-voice.diff (0.6 KiB)
Closed by  sdoyon
2007-11-27 13:48
Reason for closing:  Accepted
pondlife commented on 2007-11-27 07:20

I agree, this used to confuse me, and it still annoys me.
We don't attempt to keep old versions of the other build processes; why should voice be any different.

rasher commented on 2007-11-27 10:48

I don't remember why I added the protection, but if it's annoying, I have no problem with removing it.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing