FS#8236 : make voice should overwrite existing .voice files.

FS#8236 - make voice should overwrite existing .voice files.

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Tuesday, 27 November 2007, 03:50 GMT
Last edited by Stephane Doyon (sdoyon) - Tuesday, 27 November 2007, 13:48 GMT

Task Type	Patches
Category	Build environment
Status	Closed
Assigned To	No-one
Operating System	All players
Severity	Low
Priority	Normal
Reported Version	Daily build (which?)
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

Rerunning make voice generates an english-1.voice, and then again an
english-2.voice... There's extra code to do this, so perhaps there's a
reason for this behavior? I can't imagine what it is.

I find this inconvenient and confusing. I was trying out encoder settings
and it took me a while to figure out that my english.voice wasn't
actually being regenerated.

So unless there's a reason for this, I'd like to commit the attached
patch.

overwrite-dot-voice.diff (0.6 KiB)

This task depends upon

Closed by Stephane Doyon (sdoyon)
Tuesday, 27 November 2007, 13:48 GMT
Reason for closing: Accepted

Comments (2)
Related Tasks (0/0)

Comment by Steve Bavin (pondlife) - Tuesday, 27 November 2007, 07:20 GMT

I agree, this used to confuse me, and it still annoys me.
We don't attempt to keep old versions of the other build processes; why should voice be any different.

Comment by Jonas Häggqvist (rasher) - Tuesday, 27 November 2007, 10:48 GMT

I don't remember why I added the protection, but if it's annoying, I have no problem with removing it.

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#8236 - make voice should overwrite existing .voice files.

Details

Loading...