Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#8321 : Fix bug when playing last track

Rockbox

Tasklist

FS#8321 - Fix bug when playing last track

Attached to Project: Rockbox
Opened by Lee Kang Hyuk (alwaysbluepop) - Friday, 14 December 2007, 07:29 GMT
Last edited by Jonathan Gordon (jdgordon) - Thursday, 24 December 2009, 07:13 GMT
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

when playlist is long enough, and when you're playing last track of the playlist, "view current playlist" will not show the last item propperly.
so fix this, by drawing set_title prior to select_item.
any other parts using list.h does not have this bug, i think.
   plviewer_ensure_displaying_la... (0.7 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 24 December 2009, 07:13 GMT
Reason for closing:  Accepted
Additional comments about closing:  better late than never :) accepted in r24108.
Comment by Marc Guay (Marc_Guay) - Thursday, 03 April 2008, 01:42 GMT
I couldn't replicate this on the e200 w/ 16929. Could you estimate how long the playlist needs to be and explain if you need to arrive at it naturally or if you can skip to the last track?
Comment by Lee Kang Hyuk (alwaysbluepop) - Sunday, 06 April 2008, 12:02 GMT
I still can see this happen. Tested on x5 target and e200 sim, with r16929 and r16976. With Default settings and default theme.
List that exceeds screen height is enough. The way to reach to the last track doesn't matter. I'll attach some screenshots. In this screenshot, I inserted 17 songs and played the 17th, and did 'view current playlist'. The last line(which line selector is located) did not displayed.
   view_current_playlist_bug.zip (26.2 KiB)
Comment by Marc Guay (Marc_Guay) - Sunday, 06 April 2008, 15:33 GMT
I see it now. Able to reproduce on e200 w/ r16973.

Loading...