FS#8361 - Custom Stereo width settings revert to plain vanilla stereo on treble setting change

Attached to Project: Rockbox
Opened by BenjaminBrown (ben_b) - Sunday, 23 December 2007, 06:15 GMT
Last edited by Dan Everton (safetydan) - Monday, 07 July 2008, 08:19 GMT
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


There is a glitch that reverts sound setting from custom stero width to stereo output when adjusting the sound settings treble.
To reproduce this bug on an E200,
Play a music file then press the menu button (down)
navigate to settings>Sound Settings
choose "Channel Configuration" and set to custom
choose "Stereo Width" set to 255
now go "Treble" change up or down a few clicks and press select, as a matter of fact selecting the old value does it as well
Did you hear the sound width change?
now go back to "Channel Configuration" and choose custom again
Did you hear it go back to 255 % ?
note:I had eq disabled, crossfeed off, and ditering off but seems to do it no matter what these are configured or set to.
not sure if it effects other players or not
Anyone with something other than an E200 want to see if it happens there too?
This task depends upon

Closed by  Dan Everton (safetydan)
Monday, 07 July 2008, 08:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  Good spotting. I've committed your patch.
Comment by Marc Guay (Marc_Guay) - Monday, 07 April 2008, 22:37 GMT
Confirmed with e200 & r17030.
Comment by Dan Everton (safetydan) - Saturday, 05 July 2008, 22:26 GMT
I'm guessing this has something to do with the e200 having software tone controls. So this bug should affect any target without hardware bass/treble.
Comment by Tomer Shalev (tomers) - Sunday, 06 July 2008, 06:01 GMT
I couldn't notice the Stereo Width change in Sansa's e200 simulator. Is it implemented by the simulator?
Comment by Tomer Shalev (tomers) - Sunday, 06 July 2008, 14:56 GMT
This does not happen when changing bass, but it happens when changing treble, although the audiohw_set_bass() and audiohw_set_treble() are pretty much alike.
Comment by Tomer Shalev (tomers) - Sunday, 06 July 2008, 22:05 GMT
Issue solved!

There is a missing break directive in a switch statement in apps/dsp.c

Please commit this fix.

BTW, please ignore my last comment, which is totally wrong.