• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Spanky - 2007-12-30
Last edited by linusnielsen - 2008-01-09

FS#8388 - MPEG Resume Time & Shutdown

Wonderfull work on the new features of the MPEG Player, but there are 2 bugs that I have noticed. I will play a movie and if I put the player on hold (so that I don’t accidentally press a button and disturb playback) the player will count this time toward the idle time and shut down in 3 minutes (what I have it set at).

Also, the Resume Time does not update. Example: I started a movie and got 2 minutes into it and stopped it (pressed and held play/pause). I came back to the movie and told it to resume at the 2 minute mark. Then I stopped it again at 5 minutes. I came back a third time and went to the resume time but it was at 2 minutes.

Closed by  linusnielsen
2008-01-09 14:41
Reason for closing:  Fixed
MikeS commented on 2007-12-30 17:52

This is all regarding the latest SVN version?

For the first I don’t know and never really got into that but will check this out.

For the second, I can say with certainty it does record the current time of playback every time playback is stopped. It could be something else regarding actually saving the data to the config file but testing play, resume, stop, resume right now on a Gigabeat F and 3g iPod shows no trouble with updating the resume time.

This was with build r15980 with my iPod 4G Photo. I saw what I saw. I will try the newest build today and report back.

I found out what happened. The player turns off while playing movies after a certain amount of time. When it does this it doesn’t remember where my place was so it went back to the earlier resume time. I think if the shutting down problem is fixed that the other one won’t need to be worried about.

Uh, oh. I forgot to mention 1 thing. I upgraded versions and I am now on r15983.

MikeS commented on 2007-12-31 08:11

It does technically handle SYS_POWEROFF now and saves the resume point which is the same code used to handle SYS_USB_CONNECTED. I check on my Gigabeat really quickly and plugging USB saves the resume point properly. Just a guess but SYS_POWEROFF may not be received properly. Hmmm.

Alright. If you need, I can test whenever. I get a notification when I get a email so when you respond or something I don’t mind helping out any way I can.

MikeS commented on 2008-01-07 16:09

1) I tried using hold on gigabeat while playing and it didn’t shut down. I had to pause it it do that.

2) I looked deeper and the problem is really the menu system behavior. The system events that would require a save don’t get “bubbled-up” from deeper menu levels and the default event handler just eats the SYS_POWEROFF message, shuts down the player and never returns so the save is never performed. The menu system really should allow overrides of the default handling of events instead of just calling default_event_handler.

Project Manager

There is such an override, in the default_event_handler_ex() function, which can call a callback function when it is about to turn off the player. Or you can do as I did when fixing this, call save_settings() before calling default_event_handler().


Available keyboard shortcuts


Task Details

Task Editing