• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Database
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by alwaysbluepop - 2008-01-07
Last edited by miipekk - 2008-01-07

FS#8423 - Fixes two database problem

I’ve noticed that tag cache system does not work properly on a certain situation, since r15955. (X5 player and sim, ‘load to ram’,’auto update’, and ‘dircache’ enabled)

1. deleted file’s tag entry continues to show up even when that tags are no longer in use in database:
deeply looked into logf, and diff between 15954 and 15955, I finally concluded that necessary codes are removed by accident.
FLAG_DELETED is not saved to masterfd, so the value of in_use[tag] is always minimum 1, not 0.
This situation may causes FS8414(duplicated entries).

2. Whenever I modified a metadata(and do not rename it), Rockbox results in crash(FS8384):
due to newly added ‘Resurrection’ code, we have to refference old tag_seek, i guess.

I’m not sure if it’s right solution, but worked as expected by now, including ‘Preserve Runtime Statistics’.

Closed by  miipekk
2008-01-07 15:10
Reason for closing:  Accepted

Thanks, this looks great. Going to commit now.


Available keyboard shortcuts


Task Details

Task Editing