FS#8447 - renames langs with latin chars

Attached to Project: Rockbox
Opened by harry tu (bookshare) - Saturday, 12 January 2008, 05:00 GMT
Last edited by Jonas Häggqvist (rasher) - Sunday, 27 July 2008, 16:54 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Localized lang names which used latin chars. (100.8 KiB)
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Sunday, 27 July 2008, 16:54 GMT
Reason for closing:  Invalid
Additional comments about closing:  The patch included is not useful. More discussion on this subject in  FS#7637 
Comment by Peter D'Hoye (petur) - Sunday, 13 January 2008, 19:37 GMT
ehm... all I see in that patch are lines starting with '-'
what's the meaning of this?
Comment by harry tu (bookshare) - Sunday, 13 January 2008, 22:31 GMT
It is a zipped up patch. You need winzip or another similar tool.
Comment by Peter D'Hoye (petur) - Monday, 14 January 2008, 07:28 GMT
I'm not _that_ stupid ;)
I was talking about the patch inside....
Comment by harry tu (bookshare) - Tuesday, 15 January 2008, 04:06 GMT
Is this better? I did one more that I missed the first time around and redid the whole thing. (126.9 KiB)
Comment by Peter D'Hoye (petur) - Tuesday, 15 January 2008, 07:18 GMT
can't open the zip...
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 15 January 2008, 08:30 GMT
I don't understand this patch. All it does is to remove czech.lang, norsk.lang, portugues.lang, finnish.lang and espanol.lang.
Comment by Peter D'Hoye (petur) - Tuesday, 15 January 2008, 08:50 GMT
which was my point in my first comment.... ;)
Comment by harry tu (bookshare) - Wednesday, 16 January 2008, 00:59 GMT
It renames them to cestina.lang, castiliano.lang and all the other localised names.
Comment by Peter D'Hoye (petur) - Wednesday, 16 January 2008, 13:25 GMT
It does not... the patch only removes them
Comment by harry tu (bookshare) - Thursday, 17 January 2008, 02:42 GMT
What am I doing wrong? All I am typing in is svn rename apps/lang/czech.lang apps/lang/cestina.lang and so on for all the other languages. Then I do svn diff app/lang >lang.patch. What is wrong?
Comment by Peter D'Hoye (petur) - Thursday, 17 January 2008, 08:26 GMT
maybe it is best to just list the new names and not try to make a patch?
To make your patch, I think you need to add the renamed files as new ones and do a remove on the old ones.
Comment by Jonas Häggqvist (rasher) - Thursday, 17 January 2008, 16:15 GMT
Renaming the languages needs to be done with some consideration. If we simply rename and do nothing, users will end up with languages that never update (say some guy has set his language to finnish.lang, and updates go into suomi.lang). Would it perhaps be possible to break the current languages, such that they won't load and/or produce an error? Or perhaps truncate them so they don't include any strings.

For a transition period of course, after which the old ones should be deleted entirely.