Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bookshare - 2008-01-12
Last edited by rasher - 2008-07-27

FS#8447 - renames langs with latin chars

Localized lang names which used latin chars.

   renlang.zip (100.8 KiB)
Closed by  rasher
2008-07-27 16:54
Reason for closing:  Invalid
Additional comments about closing:  

The patch included is not useful. More discussion on this subject in  FS#7637 

petur commented on 2008-01-13 19:37

ehm… all I see in that patch are lines starting with ‘-’ what’s the meaning of this?

It is a zipped up patch. You need winzip or another similar tool.

petur commented on 2008-01-14 07:28

I’m not _that_ stupid ;)
I was talking about the patch inside….

Is this better? I did one more that I missed the first time around and redid the whole thing.

   lang.zip (126.9 KiB)
petur commented on 2008-01-15 07:18

can’t open the zip…

Project Manager

I don’t understand this patch. All it does is to remove czech.lang, norsk.lang, portugues.lang, finnish.lang and espanol.lang.

petur commented on 2008-01-15 08:50

which was my point in my first comment…. ;)

It renames them to cestina.lang, castiliano.lang and all the other localised names.

petur commented on 2008-01-16 13:25

It does not… the patch only removes them

What am I doing wrong? All I am typing in is svn rename apps/lang/czech.lang apps/lang/cestina.lang and so on for all the other languages. Then I do svn diff app/lang >lang.patch. What is wrong?

petur commented on 2008-01-17 08:26

maybe it is best to just list the new names and not try to make a patch?
To make your patch, I think you need to add the renamed files as new ones and do a remove on the old ones.

Renaming the languages needs to be done with some consideration. If we simply rename and do nothing, users will end up with languages that never update (say some guy has set his language to finnish.lang, and updates go into suomi.lang). Would it perhaps be possible to break the current languages, such that they won’t load and/or produce an error? Or perhaps truncate them so they don’t include any strings.

For a transition period of course, after which the old ones should be deleted entirely.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing