Rockbox

My initial forum posting on this issue is here : http://forums.rockbox.org/index.php?topic=15143.0

Complications (to me) in fixing this across the 1G/2G/3G include:
The 1G seems to use GPIO B bit 0 for scrollwheel enable, and the same bit is used by the 2G for headphone detection
The 1G and 2G seem to be logically grouped in the code
I’m not sure if the 3G is also broken.

I was thinking of proposing something like:
bool headphones_inserted(void)
{
#ifdef IPOD_1G2G

  return (GPIOB_INPUT_VAL & 0x1)?true:false;

#else

  return (GPIOC_INPUT_VAL & 0x1)?true:false;

#endif
}
to leave the 3G untouched, but this also means that the 1G will be seeing the scrollwheel enable state. Maybe someone who has more experience can unravel a solution.

This is probably a bit better in terms of the 1G and 2G (still need to find if the 3G is currently broken too - I’m posting a forum topic for user feedback):

bool headphones_inserted(void)
{
#ifdef IPOD_1G2G

  if ((IPOD_HW_REVISION >> 16) == 2)
  {
	return (GPIOB_INPUT_VAL & 0x1)?true:false;
  }
  else
  {
	/* 1G has no headphone detection, so fake insertion */
	return (true);
}

#else

return (GPIOC_INPUT_VAL & 0x1)?true:false;

#endif
}

FYI - Headphone detection works fine on my 3G iPod with current release code.

Thanks Bill.
I’ve filed a patch for this under  FS#8920  that leaves the 3G detection method unchanged, and fixes it for the 2G.