FS#8529 - Gather Runtime broken starting with r16025

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Tuesday, 29 January 2008, 21:10 GMT
Last edited by Steve Bavin (pondlife) - Sunday, 09 March 2008, 18:22 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


On rebuffering it only gathers runtime data (e.g. playcount) for the last track. I.e. playing an album with 10 titles where the first 6 tracks fit into the buffer it will only record the info for track 6 and not for tracks 1-5.

Noticed on the gigabeat current version and tracked back with the gigabeat sim to revision 16025 (i.e. still okay with r16024).
This task depends upon

Closed by  Steve Bavin (pondlife)
Sunday, 09 March 2008, 18:22 GMT
Reason for closing:  Fixed
Comment by Ben Zavala (bzavala) - Sunday, 03 February 2008, 00:59 GMT
Confirmed that this is also happening on iPod video.
Comment by Robert Kukla (roolku) - Tuesday, 05 February 2008, 11:37 GMT
Until nico_p comes back from his skiing holidays to fix it, you can revert his commit to still keep the runtime data accurate.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 05 February 2008, 11:41 GMT
I'm back but still catching up. I promise to look into this ASAP.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 05 February 2008, 12:05 GMT
After a bit of thinking, I'm pretty sure that the only hunk you need to apply from the patch you gave is the third one. Setting elapsed to 0 will cause the unbuffer callback not to log the tracks. I need to do some testing before I commit the fix.
Comment by Steve Bavin (pondlife) - Tuesday, 04 March 2008, 17:35 GMT
Is this still a problem?
Comment by Ben Zavala (bzavala) - Tuesday, 04 March 2008, 18:10 GMT
To me, it still happens, except that the only track that updates is the first track played. Weird.. isn't it?

I'm using r16456.

Comment by Shiloh Hawley (gree665) - Wednesday, 05 March 2008, 17:14 GMT
Using r16524, only the last track in the playlist is added to the "recently played tracks" list.
Comment by Shiloh Hawley (gree665) - Sunday, 09 March 2008, 17:14 GMT
Seems to work now, r16546 must have fixed it!