Rockbox

Tasklist

FS#8565 - possible fix for runtime data causing extra spin ups

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Friday, 08 February 2008, 18:27 GMT
Last edited by Miika Pekkarinen (miipekk) - Sunday, 17 February 2008, 18:36 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

this code is com[pletly untested and I didnt even try compiling it yet.

someone with a hard disk target needs to check if this works.. i'm posting this more for the idea than anything...
   896033.txt (1.7 KiB)
This task depends upon

Closed by  Miika Pekkarinen (miipekk)
Sunday, 17 February 2008, 18:36 GMT
Reason for closing:  Accepted
Comment by x (vmh) - Friday, 08 February 2008, 21:41 GMT
I couldn't compile. There's an error with ata_idle_notify(...) because ata_idle_notify is only a type. I replaced it with register_ata_idle_func(...). Now I only get some warnings.

I don't know if it really fix the extra spin ups, but what I can say is I don't have the high noise at startup anymore (point 1 from  FS#8498 ).
Comment by Jonathan Gordon (jdgordon) - Monday, 11 February 2008, 04:12 GMT
test me!
   tagcache.diff (1.7 KiB)
Comment by Jonathan Gordon (jdgordon) - Monday, 11 February 2008, 06:17 GMT
right, I've had a bit of a play and i give up!
the code should work (obviously :p ) and the if (force || command_queue_is_full()) case is not happening which makes me pretty certain something else is spinning up the disk on a track change.

Loading...