FS#8572 - USLT lyric viewer
Opened by Lechner Michael (smoking_gnu) - Saturday, 09 February 2008, 19:36 GMT
Last edited by Teruaki Kawashima (teru) - Saturday, 09 October 2010, 03:23 GMT
|
DetailsThis viewer reads the USLT lyrics from a mp3 file and displays them using a gui_list.
You have to select "open with.." on a mp3 file in the file browser to show the lyrics. I tested it on the sim and on my X5. |
Saturday, 09 October 2010, 03:23 GMT
Reason for closing: Out of Date
Additional comments about closing: lrcplayer in SVN would do this.
If there's no lyric tag in the file it now doesn't take age anymore till my plugin realizes it ;)
Also a few minor bugfixes and code cleanup.
http://www.rockbox.org/tracker/task/7432
I think it's better to have two different plugins, one for synchronized (sncviewer) and one for unsynchronized lyrics (this one).
1. I thought the sncviewer plugin did NOT support USLT lyrics
2. I wanted to start coding for rockbox anyway.
missing header for unified diff at line 5 of patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: CATEGORIES
|=================================================
|--- CATEGORIES (revision 16229)
|+++ CATEGORIES (working copy)
--------------------------
File to patch:
What am I doing wrong?
The patch works for me...
However I made a new one from the current SVN for you:
CC apps/plugins/lyric_viewer.c
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:32: error: conflicting types for ‘rb’
/home/nicholas/Projects/rockbox/apps/plugin.h:900: error: previous declaration of ‘rb’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:37: error: conflicting types for ‘rb’
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:32: error: previous declaration of ‘rb’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:39: warning: unused parameter ‘buf_len’
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:192: error: conflicting types for ‘plugin_start’
/home/nicholas/Projects/rockbox/apps/plugin.h:902: error: previous declaration of ‘plugin_start’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c: In function ‘plugin_start’:
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:215: error: too many arguments to function ‘rb->splash’
make: *** [/home/nicholas/Projects/rockbox/ipod/apps/plugins/lyric_viewer.o] Error 1