Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Lechner Michael - 2008-02-09
Last edited by Teruaki Kawashima - 2010-10-09

FS#8572 - USLT lyric viewer

This viewer reads the USLT lyrics from a mp3 file and displays them using a gui_list.
You have to select “open with..” on a mp3 file in the file browser to show the lyrics.
I tested it on the sim and on my X5.

Closed by  Teruaki Kawashima
2010-10-09 03:23
Reason for closing:  Out of Date
Additional comments about closing:  

lrcplayer in SVN would do this.

Lechner Michael commented on 2008-02-11 20:57

Small update: now it reads the length of the ID3 tag before it starts searching for the lyric tag;
If there’s no lyric tag in the file it now doesn’t take age anymore till my plugin realizes it ;)
Also a few minor bugfixes and code cleanup.

Pascal Briehl commented on 2008-02-12 05:26

this could probably merged with the sncviewer plugin
http://www.rockbox.org/tracker/task/7432

x commented on 2008-02-12 14:55

I added USLT support to the sncviewer back in November 2007 due to some requests, but the plugin wasn’t intended for unsynchronized lyrics.
I think it’s better to have two different plugins, one for synchronized (sncviewer) and one for unsynchronized lyrics (this one).

Lechner Michael commented on 2008-02-13 11:21

I wrote this plugin for 2 reasons:
1. I thought the sncviewer plugin did NOT support USLT lyrics
2. I wanted to start coding for rockbox anyway.

George Tamplaru commented on 2008-02-17 11:40

I am not able to apply this patch. I get (for -p0 to -p5) the following message:

missing header for unified diff at line 5 of patch
can’t find file to patch at input line 5
Perhaps you used the wrong -p or –strip option?
The text leading up to this was:


————————– File to patch:

What am I doing wrong?

Lechner Michael commented on 2008-02-17 22:36

I did not use ANY -p or –strip option… The patch works for me…
However I made a new one from the current SVN for you:

Przemysław Hołubowski commented on 2008-04-11 11:44

Could you adopt it to the new plugin API? (It does not work with recent builds).

Lechner Michael commented on 2008-04-12 20:13

Sorry, but I can’t compile right now. I’ll have a look at it on monday.

Lechner Michael commented on 2008-04-16 18:39

Here’s a new, working version (viewports broke the old one) :

Taylore commented on 2009-03-24 23:38

Was going to try this, and it patched ok, but it did not compile right… May someone please resync this please.. Thanxs, this patch seems really kool..

Nick G commented on 2009-08-06 20:47

this is what i’m getting when i try to compile. I patched with lyric_viewer.diff and then replaced lyric_viewer.c with the one above. compiling for ipod video 5g (30gb)
CC apps/plugins/lyric_viewer.c
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:32: error: conflicting types for ‘rb’
/home/nicholas/Projects/rockbox/apps/plugin.h:900: error: previous declaration of ‘rb’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:37: error: conflicting types for ‘rb’
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:32: error: previous declaration of ‘rb’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:39: warning: unused parameter ‘buf_len’
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:192: error: conflicting types for ‘plugin_start’
/home/nicholas/Projects/rockbox/apps/plugin.h:902: error: previous declaration of ‘plugin_start’ was here
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c: In function ‘plugin_start’:
/home/nicholas/Projects/rockbox/apps/plugins/lyric_viewer.c:215: error: too many arguments to function ‘rb→splash’
make: *** [/home/nicholas/Projects/rockbox/ipod/apps/plugins/lyric_viewer.o] Error 1

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing