Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by vmh - 2008-02-10
Last edited by petur - 2008-02-24

FS#8585 - jpeg_viewer: fit lcd

find optimal scale factor for the image to fit LCD as initial scale factor

   jpeg_fit_lcd.patch (0.6 KiB)
Closed by  petur
2008-02-24 23:09
Reason for closing:  Rejected
Additional comments about closing:  

this is not how we want the viewer to behave, sorry…

petur commented on 2008-02-11 22:11

What does this fix? max_downscale() does what your code does, so your code will always result in selecting ds_max.

vmh commented on 2008-02-12 08:39
max_downscale() does what your code does
No, not exactly the same. If you compare both code you'll notice max_downscale() uses 'or' and mine uses 'and'. That means in max_downscale(), both width AND hight, must be smaller than the LCD, but in my code however it's sufficient if only height OR width is smaller than the LCD.
so your code will always result in selecting ds_max
No, not always. It depends on your LCD size and the picture size.
To test it you have to use pictures of different sizes.
petur commented on 2008-02-15 08:54

To be honest, I couldn't find a picture where your code change made a difference, unless I'm doing something wrong…

vmh commented on 2008-02-24 20:12

@petur: Try with these picture. Hope you'll see a difference.

   400px-USA_Antelope-Canyon.jpg (32.4 KiB)
   400px-Palace_of_Westminster,_... (18.1 KiB)
petur commented on 2008-02-24 22:56

ok, I see the difference now, and I think I like current behaviour better than your patch: With your patch, these pictures show up partially zoomed, where SVN shows the complete picture…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing