Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Video
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Andree Boeger - 2008-02-14
Last edited by Teruaki Kawashima - 2010-11-26

FS#8607 - MPEG video playlist

If play mode = file, mpegplayer plays a video and stops at the end of the video, returning to the file browser (as it is the state now). In case of play mode = directory mpegplayer assumes a playlist which is identical to the current directory (lexically order of the files). This is the same behaviour, as if rockbox plays an audio file selected from the file browser. The playback stops when the last file in the directory has been played.

Having this playlist, you can easyly skip to the next or the previous video file by pressing the FF or RW button shortly.

It makes sense to switch the resume option to “Play from beginning”, if you want to watch one video after another, but it’s not neccessary.

Closed by  Teruaki Kawashima
2010-11-26 12:49
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r28667

Robert Kukla commented on 2008-02-18 16:24

I find this quite useful - as long as there are only few files in the directory and the skip is infrequent I think the approach is sensible (as opposed to maintaining a playlist like in the jpg viewer). The skip order is the order files are stored in the directory which is not neccessary alphabetically for FAT.

Michael Sevakis commented on 2008-05-17 19:57

I think implementing as an engine control layer would be the proper approach - not in the UI layer. Additionally, a full stream_init should _not_ be needed between files but just a stream_close/stream_open. It is designed that way in anticipation of this sort of feature.

Michael Sevakis commented on 2008-05-17 20:20

I should mention that I tried to apply this patch to SVN r17557 without success so I could have misread some aspects of the .diff.

Taylore commented on 2008-12-21 15:55

hmm… This patch looks really kool, however i got lots’o’ hunk errors also… Can someone with patch experience fix this please.?

Jacob Brooks commented on 2009-01-12 21:16
Taylore commented on 2009-01-16 21:56

lol. Thank you for resyncing it. It worked very nicely!, while it did.. I guess it it broken again,,, since i got a Hunk #10 fail at 1892 in apps/plugins/mpegplayer/mpegplayer.c (on build 19778)… Hmphh.. would you mind re-resyncing it please? thank you in advance…

Jacob Brooks commented on 2009-01-17 16:42
Jacob Brooks commented on 2009-04-18 16:25
Taylore commented on 2009-06-21 19:55

hmm.. It seems to be broken again.. One hunk error while patching.. May someone please sync this again please?

Jacob Brooks commented on 2009-07-23 23:40

I tried to figure it out but they have rewritten the api so it is pretty well mangled. This is where the change happened
http://svn.rockbox.org/viewvc.cgi/trunk/apps/plugins/mpegplayer/mpeg_settings.c?r1=21305;r2=21306;pathrev=21306

Teruaki Kawashima commented on 2009-08-28 12:08

resync and change.
* short press of button for rewinding starts current video from the beginning if postition is not near the beginning regardless the resume option.

Teruaki Kawashima commented on 2010-01-13 13:29

Update patch.
* Don’t change video by pressing left or right button if in single mode.
* Add item to change video to menu.
* don’t do stream_init and stream_exit when change video. don’t know if it is done correctly.

Teruaki Kawashima commented on 2010-06-18 14:47

synced to r26919.

Teruaki Kawashima commented on 2010-11-01 15:11

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing