Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by petur - 2008-02-25
Last edited by petur - 2008-03-09

FS#8644 - Make Rockbox work with CF modded devices

Proposal to make rockbox work on targets with CF cards (modded)
Assumes identify[0] == 0x044A as CF detection
Also changes some minor stuff that I think was wrong.

The important change for CF:
- don't set powermanagement
- don't perform perform_soft_reset()

   CF.patch (4.3 KiB)
Closed by  petur
2008-03-09 13:25
Reason for closing:  Accepted
Additional comments about closing:  

committed!

At the moment, the identify[0]==0x044A check appears twice. I would propose to factor out this "CF detection" into a function (maybe inlined) or a macro, for better maintainability.

petur commented on 2008-02-26 12:29

yes, the thought has crossed my mind too (after posting the patch). Would allow to change it into a list, and possibly check once + remember

For reference, here are the values for identify[0] that we collected for various cards/disks in IRC on 2008-02-22:

044A - CF Transcend 133x 2GB (magmaniac)
044A - CF A-Data 266x 8GB (petur)
044A - iPod nano (amiconn)
0040 - HD MK8007GAH, iriver H180 (amiconn)
0040 - HD MK2004GAL, iriver H120 (magmaniac)
0C5A - HD ST660211, iriver H10 (amiconn)
848A - MicroDrive HMS360604D5CF00, iPod mini (amiconn)

Of course it'd be great if we had more data…

petur commented on 2008-02-27 20:05

adapted, also added a line containing identify[0] to disk info in the debug menu

petur commented on 2008-02-27 23:01

committed the original dump_identify from amiconn, so undo my debug_menu tweak

petur commented on 2008-03-01 16:10

new CF detection thanks to amiconn. To be tested if this influences power consumption on the H10 5GB, as its microdrive also reports itself as CF

petur commented on 2008-03-03 22:31

and another one… thanks to amiconn, we figured out that on soft_reset(), the card actually does a hard reset. So we need to reconfigure after soft_reset

Please test if this one is also stable (no freezing). Also to be tested on ipod nano.

petur commented on 2008-03-04 22:12

some cleanup

petur commented on 2008-03-06 08:21

I'm doing battery benchmarks on H10 5GB, it would be nice if somebody could test this on ipod nano

petur commented on 2008-03-07 00:57

another day, another patch

getting close to committing, this patch only uses power management bits to set power management, no more CF detection.

please test…..

petur commented on 2008-03-08 15:18

CF7 was no good…

this is a more simple take on the issue (I give up on getting it to work in a nice way)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing