• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2008-03-01
Last edited by saratoga - 2008-03-08

FS#8670 - bugfix for overflow in mpc decoder (glitches)

Here is a patch for possibles glitches with mpc-playback. The was caused through internal overflow in the snythesis filter. This patch re-inserts a pre-/postscaling like it was implemented before the performance optimizations.

Closed by  saratoga
2008-03-08 21:26
Reason for closing:  Accepted

Update to have better "native" support for the optimizations which were made 6 months ago. Also this should still work for upocming float-versions.

Now with patch.

Want me to commit this now or do you want to look at it more first?

Also, have you looked at SV8 support? I'm wondering how difficult it would be to support.

As this fix doesn't harm anything → please commit :o)

Regarding the sv8-support: I did not check the sv8-sources, yet. So I can't estimate the effort… I assume the synthesis is untouched, but the bitstream decoder and requantization heavily changed. I guess large parts will need to be ported to fixed point again…

The SV7 sources were already fixed point, although not tested as much as floating point. I expect the SV8 lib status to be the same. Have you tried reporting this overflow stuff to the (current) musepack devs? I'd commit this right now, but don't have a development environment handy at the moment.


Available keyboard shortcuts


Task Details

Task Editing