Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by riksweeney - 2008-03-03
Last edited by learman - 2008-03-04

FS#8675 - Last song in playlist ends prematurely

The last song in the playlist ends a few seconds before it should do. This bug doesn’t appear to be related to a player or codec.

Steps to reproduce

Reproduction is quite simple, find a track that has music up the the last second of the track. Highlight the song in Rockbox and do Context Menu → Playlist → Insert. You can fast forward to the last 20 seconds or so of the song to avoid having to listen to the entire thing.

You’ll notice that the time remaining will say 2 seconds (roughly) and then the song will abruptly stop.

Closed by  learman
2008-03-04 18:56
Reason for closing:  Fixed
pondlife commented on 2008-03-03 16:55

This was caused by r16445 and should be fixed by the attached patch. Unfortuately I’m not experienced with bookmarks, so this will probably bring back the bug that r16445 was intended to fix…

   undo16445.patch (1.8 KiB)
riksweeney commented on 2008-03-03 18:28

Cool, that solves the problem, but I guess it’ll probably reopen the other bug…

learman commented on 2008-03-03 20:19

It would indeed reopen the bookmark bug. To fix that, after reverting 16445, the second Q_AUDIO_STOP command in codec_thread should only be sent if codec_load_next_track says it should be, i.e., in case the codec request failed. The codec thread shouldn’t be too trigger happy when it comes to stopping playback…

learman commented on 2008-03-03 20:53

This patch reverts r16445 and then fixes the bookmark problem as I described above. Seem to work as intended in the simulator.

   r16445_take_2.patch (2.5 KiB)
pondlife commented on 2008-03-04 17:34

Works for me (although I’ve not tested bookmarks). Magnus, I’ll let you commit.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing