• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mud - 2008-03-05
Last edited by barrywardell - 2008-03-12

FS#8683 - usb_core.c possible bug

In lines 477-481 of firmware/usbstack/usb_core.c (noticed in r16521) there is a possible bug. I’d make a patch but I don’t know the correct fix.

The relevant text is:

          if (req->wValue)
              usb_drv_stall(req->wIndex & 0xf, false,(req->wIndex & 0x80) !=0);
              usb_drv_stall(req->wIndex & 0xf, false,(req->wIndex & 0x80) !=0);

This is basically if(something) do_x(); else do_x(); do_y();
Very confusing at best.

I mentioned this in irc, but nobody seemed to notice. Sorry if someone is already looking into it.

Closed by  barrywardell
2008-03-12 20:18
Reason for closing:  Fixed
fg commented on 2008-03-12 16:41

Fixed. I saw it in the irc logs.


Available keyboard shortcuts


Task Details

Task Editing