Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mcuelenaere - 2008-03-05
Last edited by kugel. - 2011-06-05

FS#8687 - Use hardware interrupt handler table lookups available in DM320 interrupt controller

This is the modifications to system-dm320.c also included in  FS#8686 .

   cat.diff (4.4 KiB)
Closed by  kugel.
2011-06-05 11:35
Reason for closing:  Out of Date
Additional comments about closing:  

There doesn't seem to be interest in this anymore. Open a new task if this is wrong.

Woops, spelling mistakes:

These are the …

As owner of a m:robe 500i (also DM320 platform), I’ll review this patch and make sure it doesn’t break anything on that side.

Short description:
This changes the way interrupts are handled to take advantage of the hardware looking of handler address(as described in the DM320 datasheet), it should save a few instruction in the IRQ/FIQ handlers and could save custom IRQ handler code bugs.

This patch is (partially) incorrect: after rereading the datasheet it seems EABASE0 (IO_INTC_ENTRY_TBA0 in the code) wasn’t filled in correctly; I’ll have to rework that one. But as I’ve disabled this in my patch for the ZVM it is low priority, so don’t expect it soon.

This patch uses the correct implementation (according to the datasheet), but isn’t working for some unknown reason.

   irq.diff (2.8 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing