Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System PortalPlayer-based
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2008-03-17
Last edited by nls - 2008-03-19

FS#8750 - add some ARM assembler for dsp-routines

Adding ARM assembler for the dsp-routines sample_output_mono() and sample_output_stereo(). Saves roughly 0.6MHz during playback of 44.1kHz stereo playback.

   dsp_asm_v01.patch (3.8 KiB)
Closed by  nls
2008-03-19 17:25
Reason for closing:  Accepted
Buschel commented on 2008-03-17 14:17

New version:
- minor change after discussion in IRC (other solution for "bx lr")
- added ARM assembler channels_process_sound_chan_karaoke() – can be further optimized, but has nearly no influence on CPU-load

Buschel commented on 2008-03-17 14:17

Now with attached patch.

   dsp_arm_v02.patch (4.8 KiB)
Buschel commented on 2008-03-17 20:51

Using faster clipping (suggested by preglow). Total speed up for stereo-signals is +22% now.

   dsp_arm_v03.patch (4.6 KiB)
Buschel commented on 2008-03-17 21:44

Final version tonight, added ARM asm for channels_process_sound_chan_mono().

Buschel commented on 2008-03-17 21:45

Now with attached patch.

   dsp_arm_v04.patch (5.5 KiB)
Buschel commented on 2008-03-18 11:43

Next patch version for further speed up. Changes:

- store 2 halfword samples via packing into 1 word
- process 2 samples in each loop → use of ldm and stm possible

ToDo: Odd sample counts are not handled properly. On odd counts the routines will process an additional (not needed) sample. This should not end up in any bad effects as odd counts will always access a valid buffer address (odd counts are always smaller than SAMPLE_BUF_COUNT/2).

Speed of this patchversion vs. C-code:
- sound processing mono: +76%
- sound processing karaoke: +77%
- playback mono: +83%
- playback stereo: +41%

   dsp_arm_v05.patch (7 KiB)
Buschel commented on 2008-03-18 20:26

Next patch after review via irc.

- within sound processing mono/karaoke the division by 2 is done before adding/subtracting to avoid possible overflow
- added a note regarding the behaviour with odd sample counts (tested and showed no negative effect)
- only perform yield() in dsp.c each tick, not each 128 samples

   dsp_arm_v06.patch (8.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing