FS#8763 - Add posibility of 10 more predefined images in WPS definition

Attached to Project: Rockbox
Opened by Henrik Johnson (hpj) - Thursday, 20 March 2008, 05:52 GMT
Last edited by Dave Chapman (linuxstb) - Sunday, 23 March 2008, 23:46 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Very simple patch to add support for 10 more predefined images. Apart from a-zA-Z as ID:s you can with this also add 0-9. Seems like a fairly low impact change and since at least for me I run into the image index limit all the time (I really like having 11 images for the rating).
This task depends upon

Closed by  Dave Chapman (linuxstb)
Sunday, 23 March 2008, 23:46 GMT
Reason for closing:  Rejected
Additional comments about closing:  The "bitmap strips" feature is now implemented, which in theory allows up to 2704 bitmaps in a WPS.
Comment by Henrik Johnson (hpj) - Thursday, 20 March 2008, 05:53 GMT
Huh, somehow the patch didn't stick. Here it is anyway.
Comment by Dave Chapman (linuxstb) - Thursday, 20 March 2008, 08:52 GMT
IMO, (and this idea has been discussed in IRC a few times, but has got no further) a better solution to the problem of the image limitation would be to add support for "icon bitmap strips". i.e. all images for the same conditional (volume, battery, codec type etc) would be in a single bitmap (arranged vertically), and then Rockbox would simply display the appropriate bitmap from that strip, depending on the value of the conditional.

This would obviously greatly reduce the number of bitmaps needed in a WPS.