• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by hpj - 2008-03-20
Last edited by linuxstb - 2008-03-23

FS#8763 - Add posibility of 10 more predefined images in WPS definition

Very simple patch to add support for 10 more predefined images. Apart from a-zA-Z as ID:s you can with this also add 0-9. Seems like a fairly low impact change and since at least for me I run into the image index limit all the time (I really like having 11 images for the rating).

Closed by  linuxstb
2008-03-23 23:46
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

The "bitmap strips" feature is now implemented, which in theory allows up to 2704 bitmaps in a WPS.

hpj commented on 2008-03-20 05:53

Huh, somehow the patch didn’t stick. Here it is anyway.

IMO, (and this idea has been discussed in IRC a few times, but has got no further) a better solution to the problem of the image limitation would be to add support for “icon bitmap strips”. i.e. all images for the same conditional (volume, battery, codec type etc) would be in a single bitmap (arranged vertically), and then Rockbox would simply display the appropriate bitmap from that strip, depending on the value of the conditional.

This would obviously greatly reduce the number of bitmaps needed in a WPS.


Available keyboard shortcuts


Task Details

Task Editing