Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System iPod 1G/2G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by yapper - 2008-03-21
Last edited by speachy - 2020-07-28

FS#8778 - iPod 1G scrollwheel not enabled

This is a simple workaround for the issue documented in  FS#8745  (scrollwheel on some 1G iPods not being enabled as the revision field is not being read as ‘1’).

This patch simply looks at the revision, and if it is not 2, assumes the revision is 1.

Closed by  speachy
2020-07-28 01:08
Reason for closing:  Accepted
Additional comments about closing:  

A decade later, this is finally merged as 5e726166.

Resync.

updated patch to not include unrelated whitespace changes and resync to r20007.

Is this a contender for 3.2? Or is there a downside?

The main problem I see is that while it has worked for everyone that needed the patch (users of (older?) 1Gs), very few people who don't need the patch (2G users and (newer?) 1Gs) have tested it.

I've tested on my 2G (r20141) without any issues, but I don't know of anyone else.

I tested this patch on my 2G iPod (r20137 was the last revision I used on it), and have had no problems whatsoever. I think it should be committed.

I noticed some discussion in IRC about the possible risks of this patch. Long ago, I tested the possible adverse affect of mistakenly treating a 2G as if it were a 1G. This is documented back in the forum thread were this issue was first identified (http://forums.rockbox.org/index.php?topic=15929.75 on page 6)

So what's holding up committing this? More testing on 2G devices?
http://www.rockbox.org/wiki/WebHome?topic=RockboxTesting Worth a post on the mailing list asking for 2G owner volunteers?

Also, how about this: if the build is a 1G2G build, and the ipod version is not 0, 1 or 2, then print out a splash on startup telling the user to contact the rockbox dev mailing list or join us on irc and tell us about their device.

Or, how about this: how does the OF do it?

Rob and I tested it on our 2Gs. There have been very few (2 I think) users who have ever experienced the issue that this patch 'fixes'. Other than that I think most have forgotten about this issue :-)

Hi, I have iPod 1G and with mine rockbox scroll wheel does not work(loader displays version 0xFFFFFF). I'd like some of you to commit the fix to regular build.

Two more cases of users who have used the patced version successfully: http://forums.rockbox.org/index.php?topic=20790.msg162820#msg162820

lynge commented on 2013-07-12 08:23

Got a 1G iPod (late model with 10 GB harddrive) where scrollwheel and battery indicator was not working. Applying yapper's solution for button-1g-3g.c and extending it to cover adc-ipod-1g2g.c and 1g2g/powermgmt-1g2g.c made the unit work, see attached patch.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing