Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2008-03-23
Last edited by bertrik - 2008-04-22

FS#8790 - Exit battery debug menu with standard context cancel button

All debug menus on my sansa e260 can be exited by a left-button press, except the battery menu. This patch fixes that to make it behave like the other debug menus.

   debug_battery_cancel.diff (0.6 KiB)
Closed by  bertrik
2008-04-22 19:10
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Initial patch committed. Second part skipped as discussed in my last comment.

bertrik commented on 2008-03-26 19:08

This patch goes a little further and replaces all lines like
if (button_get_w_tmo(HZ/10) == (DEBUG_CANCEL|BUTTON_REL))
with line
if (get_action(CONTEXT_STD,HZ/10) == ACTION_STD_CANCEL)

This actually makes the code smaller because it allows the removal of locally defined model specific #defines for DEBUG_CANCEL.

   debug_battery_cancel_2.diff (3 KiB)
bertrik commented on 2008-04-15 19:46

resynced to 17123

   debug_battery_cancel_3.diff (3 KiB)
bertrik commented on 2008-04-19 17:52

I think I’ll commit the original patch and hold off the more elaborate change because that doesn’t really fix a reported bug and may break something for another target (which I cannot test).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing