- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System Sansa e200
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#8790 - Exit battery debug menu with standard context cancel button
All debug menus on my sansa e260 can be exited by a left-button press, except the battery menu. This patch fixes that to make it behave like the other debug menus.
Closed by bertrik
2008-04-22 19:10
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2008-04-22 19:10
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Initial patch committed. Second part
skipped as discussed in my last
comment.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
This patch goes a little further and replaces all lines like
if (button_get_w_tmo(HZ/10) == (DEBUG_CANCEL|BUTTON_REL))
with line
if (get_action(CONTEXT_STD,HZ/10) == ACTION_STD_CANCEL)
This actually makes the code smaller because it allows the removal of locally defined model specific #defines for DEBUG_CANCEL.
resynced to 17123
I think I’ll commit the original patch and hold off the more elaborate change because that doesn’t really fix a reported bug and may break something for another target (which I cannot test).