• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Database
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MoonWolf - 2008-03-25
Last edited by miipekk - 2008-04-19

FS#8795 - Fault of the escape processing in Changelog

It is tagcache.c that there is a problem.
A problem is in import/export of the tag containing double-quote or a backslash. It is reproducible.
When the worst, a database is broken and the whole Rockbox becomes unstable.

double-quote should be escaped by backslash +double-quote in a write_tag function.
Moreover, a thing when a backslash comes to the end of a tag is considered, and a backslash should also be escaped.

un-escape processing of read_tag was also modified according to it.

The above correction improves compatibility with the tool of a third party.

Closed by  miipekk
2008-04-19 23:48
Reason for closing:  Accepted

What “tool of a third party” are you referring to?

It uses for reading rating and the count of playback of music from database_changelog.txt, and writing in MediaMonkey with the independent script which has not been released yet.
The actual situation and the way of reading and writing of ‘Database’ are not document-ized.
database_changelog.txt is its only hope.


Available keyboard shortcuts


Task Details

Task Editing