Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Thomas Martitz - 2008-03-29
Last edited by Nicolas Pennequin - 2008-04-01

FS#8828 - Image check of wps doesn't lead to hard-coded wps screen

Normally, if a syntax error in a .wps occurs, rockbox will reset the wps and apply the very default one (not the wps of cabbiev2, the hard-coded one).

Lately, there was a commit which checked if all images, which the wps want to load can be loaded properly. If the check fails, the wps is rejected.

This is not the case. Just all images don’t get loaded, everything else will apply (i.e. the progress bar image will not used, but the progress bar dimensions and position are still apllied).

To reproduce:
Download a wps, which has some flawed images, i.e. this one: http://www.rockbox.org/twiki/bin/view/Main/WpsSansaE200#Razor (razor).
Load the wps and see yourself.

IMO it should reject the entire wps and show the hard-coded wps, exactly what happens if syntax errors occur.

Tested on e200 (sim and target, svn revision from 29th of March), but it possibly applies for all targets. I talked about that with linuxstb on IRC (log of 29th of march; 20:22:15 CET) allready, and he says that it should be fixed.

Closed by  Nicolas Pennequin
2008-04-01 17:47
Reason for closing:  Fixed
Additional comments about closing:  

r16914

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing