FS#8860 - File browser context menu shows unnecessary items in an empty directory

Attached to Project: Rockbox
Opened by Christopher Williams (christop) - Monday, 07 April 2008, 19:03 GMT
Last edited by Robert Kukla (roolku) - Wednesday, 09 April 2008, 13:52 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When I open the context menu (long-select) in an empty directory in the file browser, I see the following items:

Create Directory
Add to Shortcuts

None of these menu items, except for "Paste" and "Create Directory", makes sense when there are no files in the directory, and they all produce weird error messages, or no error at all:

Rename: shows the keyboard as usual but has "box" characters in the edit line. When I press the "accept" button (play button on Sansa e200), it displays "Rename failed"
Cut: no message
Copy: no message
Paste: works as usual
Create Directory: works as usual
Properties: shows the error message "File/Dir no found:" followed by a long list of "box" characters (like Rename)
Add to Shortcuts: error messages: "No parameter specified!" and "Plugin returned error"

I expected to see

a) fewer context menu items (only Create Directory and Paste) and/or
b) better error checking/recovery (plus better messages for the user)
This task depends upon

Closed by  Robert Kukla (roolku)
Wednesday, 09 April 2008, 13:52 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed in r17047
Comment by Christopher Williams (christop) - Monday, 07 April 2008, 19:13 GMT
By the way, this is the latest build, r17024-080407.