Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#8882 : Ogg files correctly go to previous track

Rockbox

Tasklist

FS#8882 - Ogg files correctly go to previous track

Attached to Project: Rockbox
Opened by Greg Erwin (Gregory) - Sunday, 13 April 2008, 06:03 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Monday, 14 April 2008, 10:52 GMT
Task Type Patches
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Ogg files no longer proceed to the next track when trying to go to the previous track.
This fixes bug  FS#8508 .

The bug was introduced in build r16025. After reverting several different changes ( http://svn.rockbox.org/viewvc.cgi/trunk/apps/playback.c?r1=16019&r2=16025&pathrev=16029 ) , I found the one that was causing the problem. Only a single line of code too. Tested using uisimulator and my own e200.
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Monday, 14 April 2008, 10:52 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 13 April 2008, 14:03 GMT
Thanks for this! I'll try to understand why the problem appeared with removing that line. I think I had a reason to delete it, I'll have to check before I apply your patch.
Comment by Greg Erwin (Gregory) - Sunday, 13 April 2008, 16:30 GMT
There probabaly was a reason. It's odd though that it only affects ogg files. I guess there is probabaly something specific to the implementation of ogg that causes it to to this, while other file types don't. I don't even have a clue where to look though.

Loading...