- Status Closed
- Percent Complete
- Task Type Bugs
- Category Rbutil
- Assigned To No-one
- Operating System Iriver H300 series
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Mr. Brownstone - 2008-04-29
Last edited by Dominik Riebeling - 2009-01-06
Opened by Mr. Brownstone - 2008-04-29
Last edited by Dominik Riebeling - 2009-01-06
FS#8948 - Building .talk files with rbutil -- long file-name problems
As title: rbutil falls over when it encounters a file-name that is around 120 characters long.
Here is a screenshot of the error, plus the console output of the command “find -iname ‘*.talk’“:
http://img254.imageshack.us/img254/9671/screenshotrbutilwg6.png
Closed by Dominik Riebeling
2009-01-06 10:51
Reason for closing: Fixed
Additional comments about closing:
2009-01-06 10:51
Reason for closing: Fixed
Additional comments about closing:
Behaviour has been changed to minimize
issues. No response from reporter so
considering this as fixed.
Hey,
i just tried to generate a Talkfile for a file with about 140 char lenght, and it was successfull.
could you provide us with this failing File, so we can reproduce the error ?
Also, which version of Rbutil are you useing ?
I’m using revision 17207 m1.0.5 as currently offered on rockbox.org. I’m using Ubuntu Hardy Heron.
Here is the file in the screenshot so you can test: http://www.clan-elite.info/band/uploads/forum_attachments/8953/01%20Pinball%20Wizard.mp3
Building the talk-files works fine after moving some of the problem files up a few folders, including for the file posted above. After generation I simply moved the files back to their original folders, along with the talk-files.
So I guess the issue is to do with a short buffer somewhere?
A short buffer sounds likely, but i just cant reproduce this problem.
I tried hard with very long filenames and paths and i cant break it, maybe it because i am on Windows and not on linux
I just tried to reproduce the issue on linux and can confirm it. After a bit of investigation it seems like espeak is the one to blame – when calling it manually with the same arguments the filename gets truncated at around 120 characters. So strictly speaking this is not a rbutil bug.
Nevertheless, rbutil should create intermediate .wav and .talk files in the systems temporary folder first and copy them afterwards. This would also address speed issues on players with slow hard discs.
The issue has been addressed in svn by putting the intermediate wav file to the systems temporary folder instead placing it to the destination path. You could still run into problems if your filenames are rather long. Please check against svn.